-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Missing DeepLinks #12820
Open
alperozturk96
wants to merge
4
commits into
master
Choose a base branch
from
bugfix/deep-link
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Handle Missing DeepLinks #12820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
bugfix/deep-link
branch
2 times, most recently
from
April 12, 2024 13:26
ca1838f
to
bf91a8a
Compare
alperozturk96
force-pushed
the
bugfix/deep-link
branch
from
April 22, 2024 12:48
6cd6ac0
to
92e96a6
Compare
alperozturk96
changed the title
Add Auto Verify For DeepLink Handler
DeepLink Handler Fix For Android 12+
Apr 24, 2024
alperozturk96
force-pushed
the
bugfix/deep-link
branch
4 times, most recently
from
April 29, 2024 06:51
6310bdd
to
8d6f792
Compare
alperozturk96
changed the title
DeepLink Handler Fix For Android 12+
Handle Missing DeepLinks
Apr 29, 2024
alperozturk96
force-pushed
the
bugfix/deep-link
branch
4 times, most recently
from
May 3, 2024 10:38
5d0d081
to
5277e65
Compare
Looks good, but can't tell if the app I'd in the manifest causes brander issues, hence cc @tobiasKaminsky |
1 task
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
bugfix/deep-link
branch
from
June 4, 2024 09:00
d7d6cd6
to
eb71f54
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12820.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
It adds auto verify for intent filters
Adds missing intent filters
Calls handleOpenFileViaIntent() function in line 564 for missing case
Note: If we support only Android 12+ we can delete path patterns and http scheme
How to Test
Note: Works for Only Android 11 and Below
adb shell am start
-W -a android.intent.action.VIEW
-d "YOUR_INTERNAL_SHARE_LINK"\
Why It's Not Working For Android 12+
In Android 12 and beyond, it's not possible to provide generic host data, and you must add an assetlinks.json file to the .well-known directory of every potential host so we can't do that.
How It's Working For Android 12+
Useful links
Our previous topic
Official Documentation
Similar Documentation